chore: augment tokenID to token vending machine #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratik151192
requested review from
cprice404,
anitarua and
allenheltondev
and removed request for
cprice404
allenheltondev
previously requested changes
Oct 24, 2023
anitarua
reviewed
Oct 24, 2023
pratik151192
dismissed
allenheltondev’s stale review
Addressed in a commit not sure why it doesnt mark as addressed
cprice404
previously approved these changes
Oct 24, 2023
|
|
||
| You can also pass a tokenId as a query string to your curl command to add context to your token. This can be particularly useful when using [Momento Topics](https://www.gomomento.com/services/topics) as the tokenId can be retrieved from subscription messages, allowing your application to distinguish between different subscribers. | ||
|
|
||
| `https://9jkmukxn68.execute-api.us-west-2.amazonaws.com/prod?name=Taylor` |
There was a problem hiding this comment.
should we be consistent in the name of the query param and what you say in the docs? you say tokenId and then the QP is name. kinda seems like the most clear thing to do is just have the QP be named tokenId as well. just a nit though, i don't feel too strongly
There was a problem hiding this comment.
I'll clarify that in this case the tokenId is the name. Good call out. The reason I want it to be more relatable to the real world is for customers to be able to derive some sense of the use case
anitarua
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
tokenIdto TVM examples. I have demonstrated this as a query string parameter as a generictokenIdwas not making sense but let me know if there's a better way to demonstrate this.